[libc++] Remove invalid char_traits instantiations from a test #142016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a test which created invalid char_traits instantiations for non-character types. This patch removes them.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesWe had a test which created invalid char_traits instantiations for non-character types. This patch removes them. Full diff: https://github.com/llvm/llvm-project/pull/142016.diff 1 Files Affected:
diff --git a/libcxx/test/std/input.output/iostream.forward/iosfwd.pass.cpp b/libcxx/test/std/input.output/iostream.forward/iosfwd.pass.cpp
index 1a28a5985a011..85fc5de128ceb 100644
--- a/libcxx/test/std/input.output/iostream.forward/iosfwd.pass.cpp
+++ b/libcxx/test/std/input.output/iostream.forward/iosfwd.pass.cpp
@@ -33,91 +33,76 @@ int main(int, char**)
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_ios<wchar_t>* >();
#endif
- test<std::basic_ios<unsigned short>*>();
test<std::basic_streambuf<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_streambuf<wchar_t>* >();
#endif
- test<std::basic_streambuf<unsigned short>*>();
test<std::basic_istream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_istream<wchar_t>* >();
#endif
- test<std::basic_istream<unsigned short>*>();
test<std::basic_ostream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_ostream<wchar_t>* >();
#endif
- test<std::basic_ostream<unsigned short>*>();
test<std::basic_iostream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_iostream<wchar_t>* >();
#endif
- test<std::basic_iostream<unsigned short>*>();
test<std::basic_stringbuf<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_stringbuf<wchar_t>* >();
#endif
- test<std::basic_stringbuf<unsigned short>*>();
test<std::basic_istringstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_istringstream<wchar_t>* >();
#endif
- test<std::basic_istringstream<unsigned short>*>();
test<std::basic_ostringstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_ostringstream<wchar_t>* >();
#endif
- test<std::basic_ostringstream<unsigned short>*>();
test<std::basic_stringstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_stringstream<wchar_t>* >();
#endif
- test<std::basic_stringstream<unsigned short>*>();
test<std::basic_filebuf<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_filebuf<wchar_t>* >();
#endif
- test<std::basic_filebuf<unsigned short>*>();
test<std::basic_ifstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_ifstream<wchar_t>* >();
#endif
- test<std::basic_ifstream<unsigned short>*>();
test<std::basic_ofstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_ofstream<wchar_t>* >();
#endif
- test<std::basic_ofstream<unsigned short>*>();
test<std::basic_fstream<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::basic_fstream<wchar_t>* >();
#endif
- test<std::basic_fstream<unsigned short>*>();
test<std::istreambuf_iterator<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::istreambuf_iterator<wchar_t>* >();
#endif
- test<std::istreambuf_iterator<unsigned short>*>();
test<std::ostreambuf_iterator<char>* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::ostreambuf_iterator<wchar_t>* >();
#endif
- test<std::ostreambuf_iterator<unsigned short>*>();
test<std::ios* >();
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
|
frederick-vs-ja
approved these changes
May 30, 2025
There was a problem hiding this comment.
Specializations for unsigned short look quite MSVC-ish, but they seemed existing since the initial commit.
I think it's perfectly fine to remove them. Even when testing non-conforming mode of MSVC (wchar_t being unsigned short), the coverage should have been complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a test which created invalid char_traits instantiations for non-character types. This patch removes them.